refactor: remove http_server and history_server rules #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
npm_bin
branch
3 times, most recently
from
7d2fb3d to
fd4e460
Compare
alexeagle
force-pushed
the
npm_bin
branch
2 times, most recently
from
09a1265 to
49f1330
Compare
BREAKING CHANGE:
history_server and http_server rules are no longer built-in.
To use them, first install the http-server and/or history-server packages
Then load("@npm//http-server:index.bzl", "http_server")
(or replace with history-server, noting that the rule has underscore where the package has hyphen)
gregmagolan
reviewed
Sep 20, 2019
| @@ -706,28 +705,6 @@ def node_repositories(package_json = [], **kwargs): | |||
| symlink_node_modules = False, | |||
| ) | |||
|
|
|||
| _maybe( | |||
gregmagolan
reviewed
Sep 20, 2019
| `; | ||
| def ${name.replace(/-/g, '_')}(**kwargs): | ||
| if "outs" in kwargs: | ||
| npm_package_bin(tool = "@${WORKSPACE}//${pkg._dir}/bin:${name}", **kwargs) |
There was a problem hiding this comment.
a comment here perhaps?. why outs is the determining attribute?
also, do additionalAttributes belong in npm_package_bin? if there is a "configuration_env_vars" additional that would likely be needed in both.
There was a problem hiding this comment.
yes, additionalAttributes are here,line 1073
There was a problem hiding this comment.
the doc for this has to go somewhere new, since it's a generated macro. I'll make a new doc for all the stuff we generate into your @npm and how to use those things
|
Resolves #1156 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
history_server and http_server rules are no longer built-in.
To use them, first install the http-server and/or history-server packages
Then load("@npm//http-server:index.bzl", "http_server")
(or replace with history-server, noting that the rule has underscore where the package has hyphen)
and change your templated_args attribute to args